From 1b296b4afc5b41d164bff474a122ce9ca3b01aea Mon Sep 17 00:00:00 2001 From: Claudio Cambra Date: Wed, 26 Mar 2025 13:44:03 +0100 Subject: [PATCH] gui/macOS: Improve overall memory management in XPCUtils::getDomainManagers Signed-off-by: Claudio Cambra --- src/gui/macOS/fileproviderxpc_mac_utils.mm | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/gui/macOS/fileproviderxpc_mac_utils.mm b/src/gui/macOS/fileproviderxpc_mac_utils.mm index 4549f4853..344031144 100644 --- a/src/gui/macOS/fileproviderxpc_mac_utils.mm +++ b/src/gui/macOS/fileproviderxpc_mac_utils.mm @@ -30,7 +30,7 @@ Q_LOGGING_CATEGORY(lcFileProviderXPCUtils, "nextcloud.gui.macos.fileprovider.xpc NSArray *getDomainManagers() { dispatch_group_t group = dispatch_group_create(); - __block NSMutableArray *managers = NSMutableArray.array; + __block NSMutableArray *const managers = NSMutableArray.array; dispatch_group_enter(group); @@ -45,8 +45,11 @@ NSArray *getDomainManagers() for (NSFileProviderDomain *const domain in domains) { qCInfo(lcFileProviderXPCUtils) << "Got domain" << domain.identifier; NSFileProviderManager *const manager = [NSFileProviderManager managerForDomain:domain]; - [manager retain]; - [managers addObject:manager]; + if (manager) { + [managers addObject:manager]; + } else { + qCWarning(lcFileProviderXPCUtils) << "Could not get manager for domain" << domain.identifier; + } } dispatch_group_leave(group); -- 2.30.2